Skip to content

llm: register sdpa variant #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2025
Merged

llm: register sdpa variant #3802

merged 5 commits into from
Sep 3, 2025

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia requested a review from peri044 August 29, 2025 23:11
@meta-cla meta-cla bot added the cla signed label Aug 29, 2025
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 29, 2025
@github-actions github-actions bot requested a review from gs-olive August 29, 2025 23:12
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review August 29, 2025 23:16
peri044
peri044 reviewed Aug 30, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Please update the supported models section in README.md and docs/user_guide.

peri044
peri044 reviewed Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you quickly try running these variants as well ?
    a) google/gemma-3-4b-it
    b) google/gemma-3-270m-it
  2. Please update the supported model list here as well: https://github.com/pytorch/TensorRT/blob/main/docsrc/tutorials/compile_hf_models.rst
  3. Could you add a testcase for 1 Gemma-3 decoder layer with sliding window attention ? The test case could be located at https://github.com/pytorch/TensorRT/tree/main/tests/py/dynamo/models as test_llm_models.py

@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests labels Sep 3, 2025
peri044
peri044 approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanluo-nvidia lanluo-nvidia merged commit 70874be into main Sep 3, 2025
87 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@gs-olive gs-olive Awaiting requested review from gs-olive

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanluo-nvidia @peri044